The latest updates on your projects. Learn more about Vercel for Git ↗︎

Hi again @sharevb This tool looks really powerful! I have tested it a bit and it seems the Timezones Date-Time Converter works fine also with multiple TZs selected. But I have some other findings/things that I don't really understand.

• What's the matter of "Current Timezone Offset (min)"? It displays an offset based on the TZ but I can also edit the value in the field which doesn't change any calculation? The value can also be copied via the button but why? Maybe I absolutely don't get it or maybe it needs some explanation in the description.
• Time is displayed in 24h format (maybe based on the browser settings?). Would be cool to be able to switch manually between 24h, am/pm and mixed like in https://www.worldtimebuddy.com
• "Country to Timezones" and "Timezones to Countries" both don't do anything if I select something there. The output doesn't change.

Hi @steffenrapp, thanks for your reporting

• What's the matter of "Current Timezone Offset (min)"? It displays an offset based on the TZ but I can also edit the value in the field which doesn't change any calculation? The value can also be copied via the button but why? Maybe I absolutely don't get it or maybe it needs some explanation in the description.

=> shows the selected timezone current timezeon offset (may be useful in case of DST) ; is now readonly

• Time is displayed in 24h format (maybe based on the browser settings?). Would be cool to be able to switch manually between 24h, am/pm and mixed like in https://www.worldtimebuddy.com

=> made a switch

• "Country to Timezones" and "Timezones to Countries" both don't do anything if I select something there. The output doesn't change.

=> should be ok now

Hi @sharevb thank you!
"Country to Timezones" and "Timezones to Countries" now work as expected.
I have two more findings:

• 24h switch is nice but only works for the output. How about the input? Or does it pick the format from the browser?
• "Current Timezone Offset" is read-only now but there is not enough space to display the content properly due to the 24h hour switch. Maybe you can improve that?

Hi @steffenrapp

• 24h switch is nice but only works for the output. How about the input? Or does it pick the format from the browser?

=> should be ok now

• "Current Timezone Offset" is read-only now but there is not enough space to display the content properly due to the 24h hour switch. Maybe you can improve that?

=> should be ok now

Hi @sharevb 👋🏼
24h switch is fine now but the copy button for "Current Timezone Offset" is still overlapping the number. On smaller screens the switch is in a new line but the number is still not readable. Maybe remove the copy button or make the field bigger?

Hi @steffenrapp, yes, removed copy icon as not so important (but overlap was not reproducable in chrome) or may be a bug of NaiveUI in your browser

Hi @sharevb thank you. Okay interesting ... in Safari the field is still a lot too small and doesn't resize according to the content. I think this field was displayed properly before the 24h switch was introduced 🤷🏻‍♂️

Hi @steffenrapp, tried another type of layout, will see...cannot reproduce as I have no iOS

Hi @sharevb yes now I can read the content on iOS in Safari, too 👍🏼 just the space between the two lines is a little big I think but on a bigger screen it looks fine.

Hi @steffenrapp, probably related to the screen side and iOs, on chrome with simulated phone mode, spacing is ok and by the way, found no property on naiveui n-space for this

@sharevb Alright, so it looks good to me from functionality side 😃 but I can't do a code review unfortunately.

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud